Fix typo identified in #172 - #173
Merged
Merged
Conversation
dliappis
marked this pull request as draft
June 25, 2025 14:01
dliappis
force-pushed
the
fix-mypy-again
branch
2 times, most recently
from
June 25, 2025 14:12
7a192ed to
b4eb92b
Compare
This commit fixes a mistake observed in elastic#172 (comment) and allows to simply the code further (no need for a helper function)
dliappis
commented
Jun 25, 2025
| - id: check-bash-syntax | ||
| - repo: https://github.com/pre-commit/mirrors-mypy | ||
| rev: v0.910 | ||
| rev: v1.16.1 |
Contributor
Author
There was a problem hiding this comment.
My understanding is that we are currently installing the latest version of mypy when executing the various Python 3.x tests using nox (e.g. see https://github.com/elastic/ecs-logging-python/blob/main/noxfile.py#L54) hence there was a discrepancy here when running precommit tests, that was surfacing non-existent errors.
dliappis
marked this pull request as ready for review
June 25, 2025 14:54
Contributor
Author
xrmx
reviewed
Jun 26, 2025
xrmx
previously approved these changes
Jun 26, 2025
xrmx
reviewed
Jun 26, 2025
xrmx
approved these changes
Jun 26, 2025
xrmx
left a comment
xrmx
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick turnaround!
hegerchr
approved these changes
Jun 26, 2025
xrmx
enabled auto-merge (squash)
June 26, 2025 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a typo observed in
#172 (comment)
Also allows to simply the code without a need for a helper function.